Add a @SuppressWarnings in advance
#7712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
matanlurey
added
the
autosubmit
auto-submit bot
added a commit
to flutter/engine
that referenced
this pull request
Sep 26, 2024
… `onSurfaceCreated`. (#55418)" (#55450)" (#55463) Reverts: #55450 Initiated by: matanlurey Reason for reverting: Fixed forward in flutter/packages#7712. Original PR Author: auto-submit[bot] Reviewed By: {fluttergithubbot} This change reverts the following previous change: Reverts: #55418 Initiated by: bdero Reason for reverting: [Engine->Framework roll breakage](flutter/flutter#155727 (comment)) Original PR Author: matanlurey Reviewed By: {jonahwilliams} This change reverts the following previous change: Closes flutter/flutter#155131. Not only did I rename the method, but I also changed the contract slightly - now `onSurfaceAvailable` is _only_ invoked _after_ `onSurfaceDestroyed` has been called. The cost is a single `boolean`, and it honestly makes the API make a lot more sense than someone having to track this themselves. /cc @johnmccutchan (OOO), and @flutter/android-reviewers.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 27, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 27, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 27, 2024
flutter/packages@f38b780...0321757 2024-09-26 [email protected] Roll Flutter from 538e742 to fa402c8 (19 revisions) (flutter/packages#7713) 2024-09-26 [email protected] [flutter_markdown] remove backgroundColor from code text theme to enable code selection highlight (flutter/packages#7090) 2024-09-26 [email protected] [interactive_media_ads] Adds internal wrapper for iOS native `IMAFriendlyObstruction` (flutter/packages#7696) 2024-09-26 [email protected] Add a `@SuppressWarnings` in advance (flutter/packages#7712) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Oct 1, 2024
flutter/packages@f38b780...0321757 2024-09-26 [email protected] Roll Flutter from 538e742 to fa402c8 (19 revisions) (flutter/packages#7713) 2024-09-26 [email protected] [flutter_markdown] remove backgroundColor from code text theme to enable code selection highlight (flutter/packages#7090) 2024-09-26 [email protected] [interactive_media_ads] Adds internal wrapper for iOS native `IMAFriendlyObstruction` (flutter/packages#7696) 2024-09-26 [email protected] Add a `@SuppressWarnings` in advance (flutter/packages#7712) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to avoid a revert like flutter/engine#55450.
/cc @jtmcdole another example of churn where I can't do the right thing without manual steps.