[google_sign_in] Add Android account name field as optional #8573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… account name. This capability is only available within Android for the underlying libraries.
neilself
requested review from
loic-sharma,
camsim99,
ditman and
stuartmorgan-g
as code owners
github-actions
bot
added
p: google_sign_in
platform-android
platform-ios
platform-web
labels
|
Apologies, I didn't mean to request review just yet. |
stuartmorgan-g
removed request for
stuartmorgan-g,
loic-sharma,
ditman and
camsim99
|
Marked as draft; once it's ready, just press the "Ready for review" button and it will re-active all the code owner review requests. |
…nstruction to test the account being constructed in the builder and then passed into GoogleSignInOptions. This is necessary as Account is an android class and cannot be instantiated normally in a unit test (the constructor will return null).
…e for a method in google_sign_in_platform_interface based on PR comments.
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 3, 2025
… interface changes) (#8735) This PR contains the platform interface changes for the main PR [8573](#8573). As a whole, these changes add a new option to explicitly specify the account name on Android while signing in within the google_sign_in package. Flutter issue: [163257](flutter/flutter#163257)
|
Once the platform interface PR auto-publishes (should be within the hour), you'll be able split out the platform-implementation-level PR. |
… subpackage now that those changes have been submitted in another PR.
…rides and depend on the new version of google_sign_in_platform_interface.
|
Hi Stuart, the platform interface is now in and this PR is passing the checks, so I believe we should be able to get it in now. |
|
This needs another PR first; see the full description of step 5 here. If landed now, anyone updating only the app-facing package (very common) would see this parameter silently ignored. |
Merged
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 6, 2025
…tation package changes) (#8805) Implementation package changes for [PR 8573](#8573). This PR adds support for a new passthrough field to explicitly set an account name while signing in for Android devices. Flutter issue: [163257](flutter/flutter#163257)
…hat clients updating to the new public API will get the new implementations.
stuartmorgan-g
added
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 10, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 10, 2025
flutter/packages@4c5a7ed...464cea5 2025-03-10 [email protected] [camera_avfoundation] Tests backfilling - part 2 (flutter/packages#8796) 2025-03-08 [email protected] [google_sign_in] Add Android account name field as optional (flutter/packages#8573) 2025-03-07 [email protected] Roll Flutter from 321fbc0 to 6b93cf9 (18 revisions) (flutter/packages#8817) 2025-03-07 [email protected] Roll Flutter (stable) from 68415ad to 09de023 (1139 revisions) (flutter/packages#8813) 2025-03-07 [email protected] [google_maps_flutter_web] set icon anchor for markers (flutter/packages#8077) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying Android library for google_sign_in allows for explicitly specifying an account name, but google_sign_in doesn't have a passthrough field for this. Android clients who want to use this functionality through google_sign_in are unable. This PR would remedy this by adding a passthrough field to expose this functionality.
Flutter issue: 163257
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.