Skip to content

[in_app_purchase] add Storefront.countryCode() and AppStore.sync() #8900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 17, 2025
Merged
Prev Previous commit
.
  • Loading branch information
LouiseHsu committed Apr 17, 2025
commit 1cbbc14b0c2d358f440cd59777a117ea3d0ece10
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ extension InAppPurchasePlugin: InAppPurchase2API {
Task {
do {
try await AppStore.sync()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing completion on success.

completion(.success(Void()))
completion(.success(()))
return
} catch {
let pigeonError = PigeonError(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ final class Storefront {
/// Returns the 3 letter code for a store's locale
/// (https://developer.apple.com/documentation/storekit/storefront/countrycode)
Future<String> countryCode() async {
final String code = await _hostApi.countryCode();
return code;
return _hostApi.countryCode();
}
}