Skip to content

[all_packages] Bump compileSdk version to 35 #9168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Apr 28, 2025

Bumps all_packages app to build with compileSdk version 35. Also updates the Gradle and AGP versions to support this new Android SDK version.

TODO: update all_packages CHANGELOG notes

Prompted by #8414.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@camsim99
Copy link
Contributor Author

Getting the failure:

* What went wrong:
An exception occurred applying plugin request [id: 'com.android.application']
> Failed to apply plugin 'com.android.internal.application'.
   > Android Gradle plugin requires Java 17 to run. You are currently using Java 11.
      Your current JDK is located in /b/s/w/ir/cache/java
      You can try some of the following options:
       - changing the IDE settings.
       - changing the JAVA_HOME environment variable.
       - changing `org.gradle.java.home` in `gradle.properties`.
...

┌─ Flutter Fix ───────────────────────────────────────────────────────────────────────┐
│ [!] Android Gradle plugin requires Java 17 to run. You are currently using Java 11. │
│                                                                                     │
│ To fix this issue, try updating to the latest Android SDK and Android Studio on:    │
│ https://developer.android.com/studio/install                                        │
│ If that does not work, you can set the Java version used by Flutter by              │
│ running `flutter config --jdk-dir=“</path/to/jdk>“`                                 │
│                                                                                     │
│ To check the Java version used by Flutter, run `flutter doctor --verbose`           │
└─────────────────────────────────────────────────────────────────────────────────────┘

I assume the build is using Java 11 because all of the plugins have sourceCompatibility, targetCompatibility as Java 11. @stuartmorgan-g is that correct?

@stuartmorgan-g
Copy link
Contributor

build_all_packages_legacy is run on a machine that installs Java 11 because we needed it still; see here and here. You'd need to bump that in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants