[various] Update example apps to Swift #9347

stuartmorgan-g · 2025-05-30T18:51:53Z

Converts the Objective-C iOS example apps for all non-iOS-plugin-implementation packages to Swift.

The process for this was (all using current stable, 3.32):

Deleted example/ios.
Ran flutter create --platforms=ios ..
Reverted changes in ios/Runner/Assets.xcassets/AppIcon.appiconset (this doesn't really matter either way, I just decided not to thrash a bunch of icons, since there's no real reason to and it would have added a ton more files).
Reverted changes outside of ios/, except for .gitignore which we may as well have a current version of.
Added license blocks to template-created code files.
Removed the RunnerTest target, its source file, and the Podfile adjustment to RunnerTest.
Reverted bundle identifier changes in most cases, since it was often auto-detecting the old io.flutter.* org the examples were first created with.
Re-added any important bits to Info.plist.
Ran a build both with and without SwiftPM enabled, to ensure that all the Cocoapods and SwiftPM boilerplate is added to the projects to cut down on random diffs when people build later.

One-off changes:

Added back Configuration.storkekit in in_app_purchase.
Migrated the Google Maps API key code in AppDelegate.m to AppDelegate.swift

I did not convert the implementation packages in this PR because those will need to be handled more carefully, due to the presence of RunnerTest (and sometimes RunnerUITest) targets that need to be preserved.

Part of flutter/flutter#148586

Pre-Review Checklist

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

stuartmorgan-g · 2025-05-30T18:52:18Z

CHANGELOG override: build details of example apps are not relevant to clients.

stuartmorgan-g · 2025-06-02T23:48:58Z

Version override: The false_secrets removal in extension_google_sign_in_as_googleapis_auth's pubspec.yaml flags for a version change, but that's not something that matters if we publish.

stuartmorgan-g · 2025-06-03T14:55:45Z

@jmagman / @vashworth Do you want me to wait for someone on the iOS team to review this, or should I just land it?

jmagman · 2025-06-11T21:14:29Z

packages/quick_actions/quick_actions/example/ios/RunnerUITests/RunnerUITests.m

-  _exampleApp = nil;
-}
-
- (void)testQuickActionWithFreshStart {


It looks like this shouldn't be deleted

jmagman · 2025-06-11T21:15:12Z

How are the PickerSaveImageToPathOperationTests.m tests passing with the images being deleted? Or is it not running any more?

stuartmorgan-g · 2025-05-30T18:54:23Z

packages/camera/camera/example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme

@@ -88,16 +91,9 @@
            ReferencedContainer = "container:Runner.xcodeproj">
         </BuildableReference>
      </BuildableProductRunnable>
-      <AdditionalOptions>
-         <AdditionalOption
-            key = "NSZombieEnabled"


Oops! This has been here since the plugin was first checked in.

stuartmorgan-g · 2025-05-30T18:55:34Z

packages/camera/camera/example/ios/Runner/main.m

-    // the unit tests, so it is better to skip the AppDelegate when running unit tests.
-    BOOL isTesting = NSClassFromString(@"XCTestCase") != nil;
-    return UIApplicationMain(argc, argv, nil,
-                             isTesting ? nil : NSStringFromClass([AppDelegate class]));


All of this logic is for XCTest, and those tests moved to camera_avfoundation when the plugin was fully federated, so this wasn't doing anything. camera_avfoundation still has this code.

stuartmorgan-g · 2025-05-30T18:58:08Z

...ages/extension_google_sign_in_as_googleapis_auth/example/ios/Runner/GoogleService-Info.plist

This has been probably-accidentally unused since #466 recreated the example app. Since this isn't the recommended way to configure Google Sign In on iOS anymore, rather than fix it here I'm just deleting the unused file. If in another 3 years someone needs it set up, they can configure it in Info.plist.

stuartmorgan-g · 2025-06-02T13:18:30Z

packages/image_picker/image_picker/example/ios/TestImages/gifImage.gif

These image files are all used in the XCTest tests that moved to image_picker_ios during full federation, so these were cruft.

stuartmorgan-g · 2025-06-02T13:21:12Z

packages/path_provider/path_provider/example/ios/RunnerTests/PathProviderTests.m

These tests were copied to path_provider_foundation during full federation, and were supposed to be deleted from here at the time to make it a move. This duplicate copy doesn't run because there's no native code in path_provider, so repo tooling doesn't attempt to run native unit tests.

stuartmorgan-g · 2025-06-02T13:25:24Z

packages/quick_actions/quick_actions/example/ios/RunnerTests/RunnerTests.m

Same as path_provider; these test files should have been deleted when they were moved to quick_actions_ios.

stuartmorgan-g · 2025-06-12T00:28:02Z

How are the PickerSaveImageToPathOperationTests.m tests passing with the images being deleted? Or is it not running any more?

The explanatory comments that I wrote when I posted the PR and then accidentally left as drafts for several weeks cover this 🤦🏻

jmagman

LGTM, thank you @stuartmorgan-g!

flutter/packages@6d3aaf4...c5ab57a 2025-06-13 [email protected] [flutter_svg] feat: Expose the renderStrategy property in SvgPicture (flutter/packages#9373) 2025-06-12 [email protected] [go_router] Add routing functions to GoRouteData (flutter/packages#9277) 2025-06-12 [email protected] [various] Update example apps to Swift (flutter/packages#9347) 2025-06-12 [email protected] Roll Flutter from 824868f to f79452e (94 revisions) (flutter/packages#9419) 2025-06-12 [email protected] [android_camera_camerax] Fix incorrect camera mirroring for front cameras on devices using `ImageReader` Impeller backend (flutter/packages#9233) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

stuartmorgan-g added 18 commits May 29, 2025 14:41

Convert shared_preferences/example

2db6139

Convert url_launcher/example

8f6dd0f

Convert path_provider/example

781ef17

Convert camera/example

513bff8

Convert image_picker/example

ec788ef

Convert webview_flutter/example

fa94e9b

Convert google_sign_in/exmaple

af1de3c

Restore use_framework! that was mistakely removed

85dbb63

Convert local_auth/example

cbd097b

Convert google_maps_flutter/example

0e8e7cb

Convert in_app_purchase/example

5f1e5b7

Convert video_player/example

d9eefec

Convert quick_actions/example

bc8b280

Convert extension_google_sign_in_as_googleapis_auth/example

d7ff0f2

Rebuild all with SwiftPM enabled, and with correct use_frameworks

81c2e6d

Restore Configuration.storekit

576c61c

Fix bundle IDs

7e27cbb

Remove unused GoogleService-Info.plist

1adad39

stuartmorgan-g requested a review from jmagman May 30, 2025 18:51

stuartmorgan-g added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label May 30, 2025

stuartmorgan-g requested review from bparrishMines, tarrinneal and ditman as code owners May 30, 2025 18:51

github-actions bot added p: extension_google_sign_in_as_googleapis_auth p: camera p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: local_auth labels May 30, 2025

github-actions bot added p: path_provider p: quick_actions platform-ios p: webview_flutter p: video_player p: url_launcher p: shared_preferences labels May 30, 2025

Remove false_secrets entry for removed file

3c273f3

tarrinneal approved these changes May 30, 2025

View reviewed changes

stuartmorgan-g added 3 commits June 2, 2025 10:38

Remove auto-added development team

f0bafd0

Re-add sign-in plist entries

f5f2d1b

Merge branch 'main' into swift-example-apps

c3dfc56

stuartmorgan-g added the override: no versioning needed Override the check requiring version bumps for most changes label Jun 2, 2025

Merge branch 'main' into swift-example-apps

a11bf0e

stuartmorgan-g added the triage-ios Should be looked at in iOS triage label Jun 5, 2025

jmagman reviewed Jun 11, 2025

View reviewed changes

stuartmorgan-g commented Jun 12, 2025

View reviewed changes

jmagman approved these changes Jun 12, 2025

View reviewed changes

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 12, 2025

auto-submit bot merged commit b90f8a7 into flutter:main Jun 12, 2025
80 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2025

b90f8a784 [various] Update example apps to Swift (flutter/packages#9347)

a9a0149

engine-flutter-autoroll mentioned this pull request Jun 13, 2025

Roll Packages from 6d3aaf4b5523 to c5ab57a54105 (5 revisions) flutter/flutter#170587

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2025

b90f8a784 [various] Update example apps to Swift (flutter/packages#9347)

f1b35cb

engine-flutter-autoroll mentioned this pull request Jun 13, 2025

Roll Packages from 6d3aaf4b5523 to c5ab57a54105 (5 revisions) flutter/flutter#170600

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[various] Update example apps to Swift #9347

[various] Update example apps to Swift #9347

Uh oh!

stuartmorgan-g commented May 30, 2025 •

edited

Loading

Uh oh!

stuartmorgan-g commented May 30, 2025

Uh oh!

stuartmorgan-g commented Jun 2, 2025

Uh oh!

stuartmorgan-g commented Jun 3, 2025

Uh oh!

jmagman Jun 11, 2025

Uh oh!

jmagman commented Jun 11, 2025

Uh oh!

stuartmorgan-g May 30, 2025

Uh oh!

stuartmorgan-g May 30, 2025

Uh oh!

stuartmorgan-g May 30, 2025

Uh oh!

stuartmorgan-g Jun 2, 2025

Uh oh!

stuartmorgan-g Jun 2, 2025

Uh oh!

stuartmorgan-g Jun 2, 2025

Uh oh!

stuartmorgan-g commented Jun 12, 2025

Uh oh!

jmagman left a comment

Uh oh!

Uh oh!

Uh oh!

[various] Update example apps to Swift #9347

[various] Update example apps to Swift #9347

Uh oh!

Conversation

stuartmorgan-g commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

stuartmorgan-g commented May 30, 2025

Uh oh!

stuartmorgan-g commented Jun 2, 2025

Uh oh!

stuartmorgan-g commented Jun 3, 2025

Uh oh!

jmagman Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

jmagman commented Jun 11, 2025

Uh oh!

stuartmorgan-g May 30, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g May 30, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g May 30, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Jun 12, 2025

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g commented May 30, 2025 •

edited

Loading