[google_maps_flutter] Annotate zIndex usage
#9462
Merged
+14
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marks intentional usage of the deprecated `zIndex`, per https://github.com/flutter/flutter/blob/main/docs/infra/Packages-Gardener-Rotation.md#deprecations On iOS, switches from `zIndex` to `zIndexInt` since it's converted to an int later anyway. Also switches the Android example app, since clients should be using the int version (and the example only uses integer values anyway).
stuartmorgan-g
requested review from
vashworth,
cbracken and
reidbaker
as code owners
stuartmorgan-g
added
the
override: no changelog needed
github-actions
bot
added
p: google_maps_flutter
platform-android
platform-ios
platform-web
labels
reidbaker
approved these changes
Jun 20, 2025
tarrinneal
approved these changes
Jun 20, 2025
stuartmorgan-g
added
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marks intentional usage of the deprecated
zIndex, per https://github.com/flutter/flutter/blob/main/docs/infra/Packages-Gardener-Rotation.md#deprecationsOn iOS, switches from
zIndextozIndexIntsince it's converted to an int later anyway. Also switches the Android example app, since clients should be using the int version (and the example only uses integer values anyway).Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3