This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Add pubspec convention checks #3984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Creates a new `pubspec-check` command that validates that pubspecs follow repo conventions: - Use of repository, not homepage - Including an issue_tracker - Ordering major sections the same way - Enables the check in CI This also fixes all issues found by the new check.
stuartmorgan-g
requested review from
bparrishMines,
cyanglaz,
gaaclarke and
LHLL
as code owners
github-actions
bot
added
p: android_alarm_manager
p: android_intent
p: battery
stuartmorgan-g
commented
May 27, 2021
| @@ -59,7 +59,6 @@ void main() { | |||
| ]), | |||
| ); | |||
|
|
|||
| print(processRunner.recordedCalls); | |||
There was a problem hiding this comment.
These changes are because I was copying from existing tests and noticed that they were spammy; this was presumably left from debugging the tests when they were being written.
ditman
approved these changes
May 27, 2021
gaaclarke
dismissed
their stale review
The link in the email didn't send me to a review with all the changes, just one patch.
stuartmorgan-g
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 28, 2021
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 28, 2021
yasargil
added a commit
to yasargil/plugins
that referenced
this pull request
Jun 2, 2021
* master: (131 commits) [in_app_purchase] fix "autoConsume" param in "buyConsumable" (flutter#3957) [video_player_web] fix: set autoplay to false during initialization (flutter#3985) [multiple_web] Adapt web PlatformView widgets to work slotted. (flutter#3964) [url_launcher] Add iOS unit and UI tests (flutter#3987) [image_picker] Change storage location for camera captures to internal cache on Android, to comply with new Google Play storage requirements. (flutter#3956) [script/tool] Use 'dart pub' instead of deprecated 'pub' (flutter#3991) [video_player] Add iOS unit and UI tests (flutter#3986) Add pubspec convention checks (flutter#3984) Enable pubspec dependency sorting lint (flutter#3983) [image_picker] Migrate maven repo from jcenter to mavenCentral (flutter#3915) [video_player] Update README.md (flutter#3975) [script/tool] speed up the pub get portion of the analyze command (flutter#3982) Revert commit e742a7b (flutter#3976) Added support to request list of purchases (flutter#3944) [google_maps_flutter] Add iOS unit and UI tests (flutter#3978) Added Windows to the description (flutter#3936) use 'flutter pub get' for both dart and flutter packages (flutter#3973) [camera] android-rework part 3: Android exposure related features (flutter#3797) Remove exoplayer workaround from everything but video_player (flutter#3980) Allow reverts when checking versions (flutter#3981) ...
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pubspec-checkcommand that validates that pubspecsfollow repo conventions:
This also fixes all issues found by the new check. No plugin version changes are included because the changes are either to examples, which don't need to be published, or the newly-discontinued plugins, for which it was simpler to just fix the violations that set up exclusions.
Fixes flutter/flutter#82913
Pre-launch Checklist
dart format. See plugin_tool format)[shared_preferences]///).