Skip to content

Move samples_index off mdc_web #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevmoo opened this issue Feb 13, 2025 · 2 comments
Closed

Move samples_index off mdc_web #2582

kevmoo opened this issue Feb 13, 2025 · 2 comments
Assignees

Comments

@kevmoo
Copy link
Contributor

kevmoo commented Feb 13, 2025

  • it's very old
  • it still uses dart:html which is now deprecated
@domesticmouse
Copy link
Contributor

Hey @ericwindmill, time to deprecate samples_index?

@domesticmouse domesticmouse changed the title Move samples_index off mdc_web Move samples_index off mdc_web Feb 13, 2025
@ericwindmill
Copy link
Contributor

I plan on removing samples_index as soon as I land a similar page on docs.flutter.dev

sfshaza2 pushed a commit to flutter/website that referenced this issue Apr 15, 2025
_Description of what this PR is changing or adding, and why:_

Adds a new page that lists all samples, codelabs, and cookbook recipes.
Samples are under-utilized, and this makes them more discoverable.
There's also a plan to retire the existing stand-alone Samples Index.

Each resource will have an associated GA custom event, which will give
us a way to compare usage of samples, codelabs and recipes (sort of).

For now, the Cookbook and Codelabs page aren't removed. and therefor
content is duplicated on this page. I don't intend on suggesting that we
remove those pages unless it's clear that folks are using this new page
to get to codelabs.

Still to-do:
- [x] A bunch of data entry. 
- [x] Add the GA custom event logic.

_Issues fixed by this PR (if any):_
* #9185 
* [samples 2582 ](flutter/samples#2582)
* [samples 2507](flutter/samples#2507)


## Presubmit checklist

- [x] This PR is marked as draft with an explanation if not meant to
land until a future stable release.
- [x] This PR doesn’t contain automatically generated corrections
(Grammarly or similar).
- [x] This PR follows the [Google Developer Documentation Style
Guidelines](https://developers.google.com/style) — for example, it
doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person).
- [x] This PR uses [semantic line
breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks)
of 80 characters or fewer.

---------

Co-authored-by: Parker Lougheed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants