ARC-V DSP extensions #89
Conversation
Remove line numbers from x-arcv-udsp-fail.l. Signed-off-by: Artemiy Volkov <[email protected]>
| @@ -3152,7 +3152,142 @@ const struct riscv_opcode riscv_opcodes[] = | |||
| {"arcv.xvwscjmul.vv", 0, INSN_CLASS_XARCVUDSP, "d,s,t,Xav", MATCH_ARCV_UDSP_XVWSCJMUL_VV, MASK_ARCV_UDSP_XVWSCJMUL_VV, match_opcode, 0}, | |||
| {"arcv.xvwscrdot.vv", 0, INSN_CLASS_XARCVUDSP, "d,s,t,Xav", MATCH_ARCV_UDSP_XVWSCRDOT_VV, MASK_ARCV_UDSP_XVWSCRDOT_VV, match_opcode, 0}, | |||
| {"arcv.xvwscjrdot.vv", 0, INSN_CLASS_XARCVUDSP, "d,s,t,Xav", MATCH_ARCV_UDSP_XVWSCJRDOT_VV, MASK_ARCV_UDSP_XVWSCJRDOT_VV, match_opcode, 0}, | |||
| {"arcv.bitrev", 0, INSN_CLASS_XARCVUDSP, "d,s,t", MATCH_ARCV_UDSP_BITREV, MASK_ARCV_UDSP_BITREV, match_opcode, 0}, | |||
There was a problem hiding this comment.
What happened to the 'arc.bitrev' for udsp related defines ? ( MATCH_ARCV_UDSP_BITREV )
Should it still exist or is it only part of the XARVBITREV ?
There was a problem hiding this comment.
this is now part of the xarcvbitrev extension, on which xarcvudsp depends
There was a problem hiding this comment.
In that case the MATCH/MASK_ARCV_UDSP_BITREV defines should be omitted as well
There was a problem hiding this comment.
Fixed, many thanks.
| arcv.bitrev t0,t3,t6 | ||
| arcv.bitrev t3,t6,t0 | ||
| arcv.bitrev t6,t0,t3 | ||
|
|
There was a problem hiding this comment.
bitrev must still be part of udsp; better to keep checking for that.
There was a problem hiding this comment.
These bitrev tests have been moved to x-arcv-bitrev* files.
The arcv.bitrev instruction actually belongs to its own extension (XARCVbitrev), rather than XARCVudsp. Remove it. Signed-off-by: Artemiy Volkov <[email protected]>
This commit implements the following extensions: XARCVbitrev v1.5.1 XARCVbitstream v1.5.1 XARCVvdsp v1.5.1 XARCVvcplx v1.5.1 XARCVvsad v1.5.1 XARCVmxmb v1.5.1 XARCVmxmc v1.5.1 XARCVmxmd v1.5.1 Signed-off-by: Artemiy Volkov <[email protected]>
Yes, all of them were. |
See commit descriptions.
Do not merge until the GCC part is published and reviewed.