Skip to content

Replace deprecated / async-unsafe lifecycles #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wuweiweiwu opened this issue Mar 15, 2018 · 4 comments
Closed

Replace deprecated / async-unsafe lifecycles #273

wuweiweiwu opened this issue Mar 15, 2018 · 4 comments
Assignees

Comments

@wuweiweiwu
Copy link
Member

wuweiweiwu commented Mar 15, 2018

bvaughn/react-virtualized#1009
https://deploy-preview-596--reactjs.netlify.com/blog/2018/03/15/update-on-async-rendering.html

Migrate to getDerivedStateFromProps

and move off soon to be deprecated lifecycle functions in react 16.x:

componentWillMount
componentWillReceiveProps
componentWillUpdate

@wuweiweiwu
Copy link
Member Author

done!

@TdyP
Copy link
Contributor

TdyP commented Aug 26, 2019

Hi there,
any idea when latest fixes around this will be released? I'm having warnings on v2.6.2 with React v16.9

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: DragSource(NodeRendererDefault), DropTarget(TreeNode)

Thanks!

@NickEmpetvee
Copy link

@TdyP is this still happening for you? I haven't tried converting my implementation yet to hooks.

@TdyP
Copy link
Contributor

TdyP commented Apr 6, 2020

@TdyP is this still happening for you? I haven't tried converting my implementation yet to hooks.

Everything is fine now, problem solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants