Skip to content

Dependencies #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 30, 2018
Merged

Dependencies #421

merged 6 commits into from
Nov 30, 2018

Conversation

dolezel
Copy link
Collaborator

@dolezel dolezel commented Nov 16, 2018

Some test are still failing and also when used in storybook, though when I use it in my project it is working.
There library used, which also needs to be upgraded, but that repo is half-abandoned :/
azuqua/react-dnd-scrollzone#38

I will try to look into it more, or if someone have time/idea - improvements are welcome :)

closes: #363
closes: #336

@coveralls
Copy link

coveralls commented Nov 19, 2018

Coverage Status

Coverage increased (+0.1%) to 74.789% when pulling d28a76e on dolezel:dependencies into 33f73db on frontend-collective:master.

@dolezel
Copy link
Collaborator Author

dolezel commented Nov 19, 2018

Fixed, though I need to depend on my https://github.com/dolezel/react-dnd-scrollzone/tree/react-dnd-6 which is fixing react-dnd-scrollzone in way compatible with this library

@dolezel
Copy link
Collaborator Author

dolezel commented Nov 19, 2018

You can also try result by npm i github:dolezel/react-sortable-tree#dist

@dolezel
Copy link
Collaborator Author

dolezel commented Nov 20, 2018

closes: #363
closes: #336

@wuweiweiwu
Copy link
Member

wow @dolezel Thanks for the huge amount of work on this!

Copy link
Member

@wuweiweiwu wuweiweiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING :) Thanks for all the work

"react-dnd-scrollzone": "^4.0.0",
"react-dnd": "^6.0.0",
"react-dnd-html5-backend": "^6.0.0",
"react-dnd-scrollzone": "github:dolezel/react-dnd-scrollzone.git#41203ef00c991f744aa87e897d7d518d32f6a994",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think in the future you can publish your own package? maybe a merge request to fix that library?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I submitted PR, but do not expect it will be merged. 🤷‍♂️

@wuweiweiwu wuweiweiwu merged commit 9343a55 into frontend-collective:master Nov 30, 2018
@wuweiweiwu
Copy link
Member

wuweiweiwu commented Nov 30, 2018

Would you like to become a maintainer of this package? I've been quite busy at work and any extra help is appreciated :)

@dolezel
Copy link
Collaborator Author

dolezel commented Nov 30, 2018

True to say, I didn't look much on how internals work. I just played with tooling on many of my projects so I have good grasp how these libs work and stick together.
But I can help with some tasks

@wuweiweiwu
Copy link
Member

@dolezel awesome! ill add you as a collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'getMonitor' of undefined Update react-dnd
3 participants