-
Notifications
You must be signed in to change notification settings - Fork 921
Dependencies #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies #421
Conversation
0685d31
to
3d56fc5
Compare
Fixed, though I need to depend on my https://github.com/dolezel/react-dnd-scrollzone/tree/react-dnd-6 which is fixing |
You can also try result by |
3d56fc5
to
d28a76e
Compare
wow @dolezel Thanks for the huge amount of work on this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AMAZING :) Thanks for all the work
"react-dnd-scrollzone": "^4.0.0", | ||
"react-dnd": "^6.0.0", | ||
"react-dnd-html5-backend": "^6.0.0", | ||
"react-dnd-scrollzone": "github:dolezel/react-dnd-scrollzone.git#41203ef00c991f744aa87e897d7d518d32f6a994", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think in the future you can publish your own package? maybe a merge request to fix that library?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I submitted PR, but do not expect it will be merged. 🤷♂️
Would you like to become a maintainer of this package? I've been quite busy at work and any extra help is appreciated :) |
True to say, I didn't look much on how internals work. I just played with tooling on many of my projects so I have good grasp how these libs work and stick together. |
@dolezel awesome! ill add you as a collaborator |
Some test are still failing and also when used in storybook, though when I use it in my project it is working.
There library used, which also needs to be upgraded, but that repo is half-abandoned :/
azuqua/react-dnd-scrollzone#38
I will try to look into it more, or if someone have time/idea - improvements are welcome :)
closes: #363
closes: #336