fix: "Uncaught Invariant Violation: Expected to find a valid target."…

[weirDozzz]

fix: "Uncaught Invariant Violation: Expected to find a valid target." after cancelling a drag into the react sortable tree

[coveralls]

Coverage remained the same at 76.492% when pulling 9a84113 on weirDozzz:master into 1c1ed8c on frontend-collective:master.

[guramnozadze]

this works

[7ruth]

Hit the same error, this looks like it works.

[redoy11]

I had also hit the same error while I was trying to do a simple tree to tree drag and drop. I tried a local build and the issue resolves. But I am not sure why this actually works. Any idea?

[hoshomoh]

This fix seems to work, but I am not sure why. @wuweiweiwu is there any reason this PR doesn't have a high prio considering it closes a lot of the open issue

[cuongdevjs]

please describe what's to do in this statement. And write a test case to make this PR available to merge and realese

[pasieronen]

I can't figure out a way to write a test case for this, but here's an attempt to describe what's happening:

// If the drag ends and the tree is still in a mid-drag state, it
// means that the drag was canceled or the dragSource dropped
// elsewhere, and we should reset the state of this tree.
//
// However, right now react-dnd is still processing its events, and
// if we unmount the mid-drag React components immediately (by calling
// this.endDrag()), that processing will run into errors (see 
// https://github.com/react-dnd/react-dnd/issues/1368 for details). 
// So let react-dnd process its events completely (which happens synchronously)
// before we call endDrag).

[mahendradambe]

Could you explain a bit this fix - it works but I'm not sure why this works? :D

It looks like setTimeout pushes the execution of this.endDrag further in the JS' task queue and we seem to be hitting an invariant violation in while/after calling this.setState({...}) via resetTree method.

Someone can correct me if the above explanation is wrong.

[dimitriacseo]

Hi ! Could this pull request be merged to the main one ?

[anthonykrivonos]

+1 on merging this PR, this is a pretty crucial bug fix. Thanks @weirDozzz!

In the meantime, you can run npm install / yarn add git+https://github.com/weirDozzz/react-sortable-tree.git to use the code off this PR.

[Divyahb]

Does this PR need anything else to be merged? We are waiting for this bugfix too. Thanks @weirDozzz

[RikuK]

Any progress here? The tree is unusable for us without this fix.

[relferreira]

How can we help to merge this PR?

[iamtofr]

seems that this is not published right now

[anthonykrivonos]

+1, @lifejuggler Can we get a new version of react-sortable-tree published?

[hacking-robot]

it doesn't solve the issue with the patch (or even master since it's on master now)

index.ts:28 Uncaught Invariant Violation: Expected to find a valid target.
    at invariant (http://localhost:3000/static/js/0.chunk.js:86649:15)
    at DragDropMonitorImpl.canDropOnTarget (http://localhost:3000/static/js/0.chunk.js:122304:77)
    at DropTargetMonitorImpl.canDrop (http://localhost:3000/static/js/0.chunk.js:233347:37)
    at nodeDropTargetPropInjection (http://localhost:3000/static/js/0.chunk.js:270846:28)
    at DragDropContainer.getCurrentState (http://localhost:3000/static/js/0.chunk.js:234955:27)
    at DragDropContainer._this.handleChange (http://localhost:3000/static/js/0.chunk.js:234849:33)
    at handleChange (http://localhost:3000/static/js/0.chunk.js:122249:13)
    at dispatch (http://localhost:3000/static/js/0.chunk.js:287020:7)
    at Object.endDrag (http://localhost:3000/static/js/0.chunk.js:122155:13)
    at HTML5BackendImpl.handleTopDragEndCapture (http://localhost:3000/static/js/0.chunk.js:231684:23)