Skip to content

Upgrade to [email protected] #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2020
Merged

Conversation

TdyP
Copy link
Contributor

@TdyP TdyP commented Jun 26, 2020

This PR upgrades react-dnd, react-dnd-html5-backend and react-dnd-test-backend to latest version (v11.1.3).
This fixes issue #665 (SortableTreeWithoutDndContext not displaying anything).

I also cleared some references to the old website folder, preventing lint script from running.

enzy added a commit to solidpixels/react-sortable-tree that referenced this pull request Jul 9, 2020
@teatalay
Copy link

Could you please apply this asap? We can't use SortableTreeWithoutDndContext at the latest version.

@lifejuggler
Copy link
Collaborator

lifejuggler commented Jul 19, 2020

The thing is, the owner of the package doesn't seem to be active.... what I have done is create my own fork of it and published it with useful changes
repo: https://github.com/lifejuggler/react-cat-tree
npm: https://www.npmjs.com/package/react-cat-tree

I'll incorporate this change there and release a version 0.0.2

@teatalay
Copy link

@lifejuggler which changes did you do?

@lifejuggler
Copy link
Collaborator

lifejuggler commented Jul 19, 2020

@teatalay, I added in missing css file that was causing prebuild fail, removed some snapshot test and going to do some overhaul like move to ts or something. I am not going to force people to switch over to mine but given that I am not part of the owner group, It might be convenient to do it like this as I really liked the library

Copy link
Member

@wuweiweiwu wuweiweiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a bunch for this!

@wuweiweiwu wuweiweiwu merged commit 9aeaf3d into frontend-collective:master Jul 30, 2020
@wuweiweiwu
Copy link
Member

will update when this is published

@TdyP
Copy link
Contributor Author

TdyP commented Aug 5, 2020

Thanks for accepting my PR :)
Do you have any idea on when the new release will be out?

@Strg-Alt-Anja
Copy link

Still waiting for this fix...? :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants