improve logs formatting, fix linting

fsspec/caching.py

@@ -79,16 +79,28 @@ def _reset_stats(self) -> None:
         self.miss_count = 0
         self.total_requested_bytes = 0
 
+    def _log_stats(self) -> str:
+        """Return a formatted string of the cache statistics."""
+        if self.hit_count == 0 and self.miss_count == 0:
+            # a cache that does nothing, this is for logs only
+            return ""
+        return " , %s: %d hits, %d misses, %d total requested bytes" % (
+            self.name,
+            self.hit_count,
+            self.miss_count,
+            self.total_requested_bytes,
+        )
+
     def __repr__(self) -> str:
         # TODO: use rich for better formatting
         return f"""
-            cache type  :   {self.__class__.__name__} 
+        <{self.__class__.__name__}:
             block size  :   {self.blocksize}
             block count :   {self.nblocks}
             file size   :   {self.size}
             cache hits  :   {self.hit_count}
             cache misses:   {self.miss_count}
-            total requested bytes: {self.total_requested_bytes}
+            total requested bytes: {self.total_requested_bytes}>
         """
 
 

fsspec/spec.py

@@ -1847,13 +1847,11 @@ def read(self, length=-1):
         out = self.cache._fetch(self.loc, self.loc + length)
 
         logger.debug(
-            "%s read: %i - %i, total: %i, cache hits: %i, cache misses: %i",
+            "%s read: %i - %i %s",
             self,
             self.loc,
             self.loc + length,
-            self.cache.total_requested_bytes,
-            self.cache.hit_count,
-            self.cache.miss_count,
+            self.cache._log_stats(),
         )
         self.loc += len(out)
         return out

fsspec/tests/test_caches.py

@@ -21,9 +21,7 @@ def test_cache_getitem(Cache_imp):
 
 
 def test_block_cache_lru():
-    """
-    BlockCache is a cache that stores blocks of data and uses LRU to evict
-    """
+    # BlockCache is a cache that stores blocks of data and uses LRU to evict
     block_size = 4
     cache = BlockCache(
         block_size, letters_fetcher, len(string.ascii_letters), maxblocks=2