Fix pagination continueCursor at end of query #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmacartney
approved these changes
Sep 4, 2024
| @@ -371,6 +371,9 @@ class DatabaseFake { | |||
| const { value, done } = this.queryNext(queryId); | |||
| if (done) { | |||
| isDone = true; | |||
| // We have reached the end of the query. Return a cursor that indicates | |||
| // "end query", which we can do with any string that isn't a valid _id. | |||
There was a problem hiding this comment.
this is magical but I'll take it
| @@ -387,7 +390,7 @@ class DatabaseFake { | |||
| return { | |||
| page, | |||
| isDone, | |||
| continueCursor, | |||
| continueCursor: continueCursor!, | |||
There was a problem hiding this comment.
Is it possible there won't be any result & it'll still be null?
There was a problem hiding this comment.
nope it's an infinite loop with two breaks and we set the variable before each break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16 and #17
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.