fix: options.diagnosticLevel not affecting logs
#2856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update * update test * update init native sdk test * Update CHANGELOG * Add additional test
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## temp/8.14.2 #2856 +/- ##
============================================
Coverage 88.91% 88.92%
============================================
Files 263 263
Lines 8951 8955 +4
============================================
+ Hits 7959 7963 +4
Misses 992 992 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
buenaflor
requested review from
krystofwoldrich and
stefanosiano
as code owners
denrase
approved these changes
Apr 14, 2025
|
ah thanks, that should not be part of the PR , I'll remove it |
buenaflor
added a commit
that referenced
this pull request
Apr 24, 2025
* Fix: Improve platform memory collection on windows/linux (#2798) * deps: bump Android from `7.22.1` to `7.22.4` (#2810) * update android deps * Update CHANGELOG.md * Fix adding runtime to contexts (#2813) * Fix CHANGELOG formatting * release: 8.14.1 * fix: `options.diagnosticLevel` not affecting logs (#2856) * v9: Set log level to `warning` by default (#2836) * update * update test * update init native sdk test * Update CHANGELOG * Add additional test * Update CHANGELOG * Update CHANGELOG * Update * Update * Fix test * Fix test * Fix analyze * Remove prod scheme * Update mocks * Update mocks * Improve performance of frames tracking (#2854) * Improve performance * Update tests * Improve performance * Formatting * Separate function * Remove separate function * Update * Improve frames tracking performance * update naming * Update * update * update * Edge case * Update mocks * formatting * Improvements * Analyze * Update mocks * Update mocks * Clean up `getSpan()` log (#2865) * Remove unnecessary log and document the behaviour * Typo * Typo * Add CHANGELOG entry * release: 8.14.2 * Update * Update --------- Co-authored-by: Denis Andrašec <[email protected]> Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: getsentry-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this will be merged in v8
Fixes user not being able to set the log level
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps