Skip to content

Logs: Models & Envelopes #2916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 7, 2025
Merged

Logs: Models & Envelopes #2916

merged 10 commits into from
May 7, 2025

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented May 7, 2025

📜 Description

  • Adds models and envelopes for log feature

💡 Motivation and Context

Relates to #2915

Closes #2921

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Logger, Log in Client, Batch Logs

Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.71%. Comparing base (18b7c08) to head (39f4130).
Report is 1 commits behind head on feat/logs.

Additional details and impacted files
@@              Coverage Diff              @@
##           feat/logs    #2916      +/-   ##
=============================================
+ Coverage      87.63%   87.71%   +0.07%     
=============================================
  Files            272      275       +3     
  Lines           9047     9089      +42     
=============================================
+ Hits            7928     7972      +44     
+ Misses          1119     1117       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@buenaflor
Copy link
Contributor

oh that was quick 👀

@denrase
Copy link
Collaborator Author

denrase commented May 7, 2025

@buenaflor First steps :)

@denrase denrase marked this pull request as ready for review May 7, 2025 11:30
@denrase
Copy link
Collaborator Author

denrase commented May 7, 2025

@buenaflor Not sure we event need separate SentryLog and SentryLogItem. Python only has Log, which corresponds to the SentryLogItem here:

https://github.com/getsentry/sentry-python/blob/b16fa5ffbad39843ebd2e9bc4ea6e91c0c9aa192/sentry_sdk/_types.py#L226

@buenaflor
Copy link
Contributor

Not sure we event need separate SentryLog and SentryLogItem. Python only has Log, which corresponds to the SentryLogItem here:

yea we dont need to separate. the item should be SentryLog

@denrase denrase requested a review from buenaflor May 7, 2025 13:01
Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@denrase denrase requested a review from buenaflor May 7, 2025 14:16
@denrase denrase merged commit 09f8959 into feat/logs May 7, 2025
163 checks passed
@denrase denrase deleted the feat/logs-envelope branch May 7, 2025 15:08
@denrase denrase mentioned this pull request May 7, 2025
10 tasks
Copy link
Contributor

github-actions bot commented May 8, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Models & Envelopes ([#2916](https://github.com/getsentry/sentry-dart/pull/2916))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 39f4130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants