-
-
Notifications
You must be signed in to change notification settings - Fork 255
Logs: Models & Envelopes #2916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logs: Models & Envelopes #2916
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/logs #2916 +/- ##
=============================================
+ Coverage 87.63% 87.71% +0.07%
=============================================
Files 272 275 +3
Lines 9047 9089 +42
=============================================
+ Hits 7928 7972 +44
+ Misses 1119 1117 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oh that was quick 👀 |
@buenaflor First steps :) |
@buenaflor Not sure we event need separate |
yea we dont need to separate. the item should be SentryLog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Models & Envelopes ([#2916](https://github.com/getsentry/sentry-dart/pull/2916)) If none of the above apply, you can opt out of this check by adding |
📜 Description
💡 Motivation and Context
Relates to #2915
Closes #2921
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps
Logger, Log in Client, Batch Logs