chore(dynamic-sampling): add hint about conditions in dynamic sampling rules #14303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
| @@ -52,6 +52,18 @@ An example of rule encoded in JSON is the following: | |||
| } | |||
| ``` | |||
|
|
|||
| <Alert title="✨ Note"> | |||
There was a problem hiding this comment.
Do we use emojies like these in our docs?
There was a problem hiding this comment.
Haha beautiful catch, i copied this from another page - seems kinda weird. I'll remove it in both places
There was a problem hiding this comment.
Oh you know what, we actually do have this in many places, now that I searched for it
constantinius
approved these changes
Jul 9, 2025
shellmayr
deleted the
shellmayr/tet-820-update-dynamic-sampling-dev-instructions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an implementation detail in dynamic sampling rules: a condition needs to be added, otherwise the ruleset is not considered valid. The documentation does not contain any reference to this, and it's frustrating to figure out the correct way of specifying a catch-all yourself, therefore I'm adding this here.