Skip to content

docs(cloudflare): Remove install for Nuxt/SvelteKit #14315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Jul 10, 2025

DESCRIBE YOUR PR

Remove the Cloudflare install as it's automatically installed.

Merged after this is released: getsentry/sentry-javascript#16873

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented Jul 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2025 1:05pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2025 1:05pm

@s1gr1d s1gr1d requested review from inventarSarah and Lms24 July 10, 2025 08:46
Copy link

codecov bot commented Jul 10, 2025

Bundle Report

Changes will increase total bundle size by 375 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.81MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 11.9MB 381 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.67MB -0.0%
../instrumentation.js -3 bytes 997.28kB -0.0%
9523.js -3 bytes 973.22kB -0.0%
../app/[[...path]]/page.js.nft.json 130 bytes 702.38kB 0.02%
../app/platform-redirect/page.js.nft.json 130 bytes 702.29kB 0.02%
../app/sitemap.xml/route.js.nft.json 130 bytes 700.26kB 0.02%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 878.27kB -0.0%
static/chunks/1831-*.js -3 bytes 421.22kB -0.0%
static/TFtrjocn1-*.js (New) 684 bytes 684 bytes 100.0% 🚀
static/TFtrjocn1-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/PA_EGTlkmGbxwdpP8t47L/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/PA_EGTlkmGbxwdpP8t47L/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Collaborator

@inventarSarah inventarSarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I've added two suggestions to change some wording -- I couldn't insert the comments directly into the relevant lines; please let me know if it's unclear what I'm suggesting there :)


</Alert>

Now you can install the Sentry Cloudflare SDK with your package manager:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this is gone, we don't need to write "First, install the Sentry ..." in the first sentence under the "Install" heading.
I think we can just combine the first two sentences:

## Install
We recommend using the Sentry wizard to automatically install the SDK in your application:

@@ -21,10 +21,6 @@ If you installed the SDK before, make sure that `@sentry/sveltekit` version `9.2

</Alert>

Now you can install the Sentry Cloudflare SDK. First, install the SDK with your package manager:
Copy link
Collaborator

@inventarSarah inventarSarah Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as for Nuxt:

Now that this is gone, we don't need to write "First, install the Sentry ..." in the first sentence under the "Install" heading.
I think we can just combine the first two sentences:

## Install
We recommend using the Sentry wizard to automatically install the SDK in your application:

@s1gr1d s1gr1d merged commit 9f1724a into master Jul 10, 2025
13 checks passed
@s1gr1d s1gr1d deleted the sig/cloudflare-install branch July 10, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants