-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(cloudflare): Remove install for Nuxt/SvelteKit #14315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 375 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I've added two suggestions to change some wording -- I couldn't insert the comments directly into the relevant lines; please let me know if it's unclear what I'm suggesting there :)
|
||
</Alert> | ||
|
||
Now you can install the Sentry Cloudflare SDK with your package manager: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that this is gone, we don't need to write "First, install the Sentry ..." in the first sentence under the "Install" heading.
I think we can just combine the first two sentences:
## Install
We recommend using the Sentry wizard to automatically install the SDK in your application:
@@ -21,10 +21,6 @@ If you installed the SDK before, make sure that `@sentry/sveltekit` version `9.2 | |||
|
|||
</Alert> | |||
|
|||
Now you can install the Sentry Cloudflare SDK. First, install the SDK with your package manager: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as for Nuxt:
Now that this is gone, we don't need to write "First, install the Sentry ..." in the first sentence under the "Install" heading.
I think we can just combine the first two sentences:
## Install
We recommend using the Sentry wizard to automatically install the SDK in your application:
DESCRIBE YOUR PR
Remove the Cloudflare install as it's automatically installed.
Merged after this is released: getsentry/sentry-javascript#16873
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: