Skip to content

fix(feedback): Dont escape url template #14324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025
+2 −2
Merged

fix(feedback): Dont escape url template #14324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
397ad99
fix(feedback): Dont escape url template
ryan953 Jul 10, 2025
f6453d0
Apply suggestion from @ryan953
ryan953 Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion develop-docs/application-architecture/feedback-architecture.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ filters, **skipping emails if:**
This feature is available if you enable the following feature flags.

- `organizations:user-feedback-ingest`
- `organizations:user-feedback-ui`
- `organizations:user-feedback-ui` (v25.6.2 and prior)
- `organizations:user-feedback-replay-clip` (from v24.7.1 through to v25.3.0)

Auto-registered flags for issue platform, for versions \<= v24.10.0 only:
Expand Down
2 changes: 1 addition & 1 deletion docs/platforms/javascript/common/user-feedback/configuration/index.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ Sentry.init({
});
```

You can link directly to a saved feedback item by implementing the `onSubmitSuccess` callback. The URL you need to construct is `https://\$\{orgSlug}.sentry.io/issues/feedback/?projectSlug=\$\{projectSlug}&eventId=\$\{eventId}`.
You can link directly to a saved feedback item by implementing the `onSubmitSuccess` callback. The URL you need to construct is `https://${orgSlug}.sentry.io/issues/feedback/?projectSlug=${projectSlug}&eventId=${eventId}`.

*Note:* In v9 and below of the SDK, the signature of `onSubmitSuccess` was `(data: FeedbackFormData) => {}`.

Expand Down