Skip to content

fix(dotnet): caching example used deprecated API #14327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,14 @@ public class MyCachingService
var cacheSpan = SentrySdk.GetSpan()?.StartChild("cache.put");

// Describe the cache server you are accessing
cacheSpan?.SetExtra("network.peer.address", "cache.example.com/supercache");
cacheSpan?.SetExtra("network.peer.port", 9000);
cacheSpan?.SetData("network.peer.address", "cache.example.com/supercache");
cacheSpan?.SetData("network.peer.port", 9000);

// Set the key you're going to use to add to the cache
cacheSpan?.SetExtra("cache.key", cacheKey);
cacheSpan?.SetData("cache.key", cacheKey);

// Optional: You can also provide the cached item's size
// cacheSpan?.SetExtra("cache.item_size", /* item size in bytes */);
// cacheSpan?.SetData("cache.item_size", /* item size in bytes */);

// Add an item to your cache
_cache.Set(cacheKey, value);
Expand All @@ -74,28 +74,28 @@ public class MyCachingService
var cacheSpan = SentrySdk.GetSpan()?.StartChild("cache.get");

// Describe the cache server you are accessing
cacheSpan?.SetExtra("network.peer.address", "cache.example.com/supercache");
cacheSpan?.SetExtra("network.peer.port", 9000);
cacheSpan?.SetData("network.peer.address", "cache.example.com/supercache");
cacheSpan?.SetData("network.peer.port", 9000);

// Set the key you're going to use to retrieve from the cache
cacheSpan?.SetExtra("cache.key", cacheKey);
cacheSpan?.SetData("cache.key", cacheKey);

// Attempt to retrieve the cached item
if (_cache.TryGetValue(cacheKey, out var cachedValue))
{
// If you retrieved a value, the cache was hit
cacheSpan?.SetExtra("cache.hit", true);
cacheSpan?.SetData("cache.hit", true);

// Optional: You can also provide the cached item's size
// cacheSpan.SetExtra("cache.item_size", /* item size in bytes */);
// cacheSpan.SetData("cache.item_size", /* item size in bytes */);

cacheSpan?.Finish();

return cachedValue;
}

// If you could not retrieve a value, it was a miss
cacheSpan?.SetExtra("cache.hit", false);
cacheSpan?.SetData("cache.hit", false);
cacheSpan?.Finish();
return null;
}
Expand Down