Skip to content

feat(flags): show ff index and generic integration doc for serverside JS #14328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Jul 10, 2025

In 9.31.0 JS SDK we started supporting featureFlagsIntegration in node. This PR shows the FF index page in node platforms with only this integration linked:
Screenshot 2025-07-10 at 4 26 26 PM

And shows the featureFlagsIntegration page for node platforms, with 9.31.0 as the min version.

Deno (server):
Screenshot 2025-07-10 at 4 46 35 PM

React (browser):
Screenshot 2025-07-10 at 4 45 21 PM

Copy link

vercel bot commented Jul 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2025 9:51pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2025 9:51pm

@codeowner-assignment codeowner-assignment bot requested a review from a team July 10, 2025 23:55
@aliu39 aliu39 requested review from a team July 10, 2025 23:56

<Alert level ="info">

If you are using an external feature flag provider, refer to the [supported list](/platforms/javascript/feature-flags/#enable-evaluation-tracking) before setting up this integration.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This alert was removed because we already link back to the eval tracking section from "next steps"

Copy link

codecov bot commented Jul 11, 2025

Bundle Report

Changes will increase total bundle size by 22.72kB (0.1%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.82MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 11.93MB 22.73kB (0.19%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.67MB -0.0%
../instrumentation.js -3 bytes 996.78kB -0.0%
9523.js -3 bytes 972.72kB -0.0%
../app/[[...path]]/page.js.nft.json 7.58kB 713.28kB 1.07%
../app/platform-redirect/page.js.nft.json 7.58kB 713.19kB 1.07%
../app/sitemap.xml/route.js.nft.json 7.58kB 711.16kB 1.08%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 879.57kB -0.0%
static/chunks/1831-*.js -3 bytes 422.11kB -0.0%
static/8CKIGMiopI7crL2hz-*.js (New) 684 bytes 684 bytes 100.0% 🚀
static/8CKIGMiopI7crL2hz-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/Ti_7Tl8aOw9Jb9v_6tDbb/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/Ti_7Tl8aOw9Jb9v_6tDbb/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Feature Flag Change Tracking Index Files

The includePath for feature flag change tracking documentation was updated from feature-flags/change-tracking-list to feature-flags/change-tracking-index in JavaScript, Python, and product issues documentation. However, the new feature-flags/change-tracking-index files are missing from this commit, resulting in missing content.

docs/platforms/javascript/common/feature-flags/index.mdx#L17-L18

<PlatformContent includePath="feature-flags/change-tracking-index" />

docs/platforms/python/feature-flags/index.mdx#L17-L18

<PlatformContent includePath="feature-flags/change-tracking-index" />

docs/product/issues/issue-details/feature-flags/index.mdx#L62-L63

<PlatformContent includePath="feature-flags/change-tracking-index" platform="_default"/>

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

@aliu39
Copy link
Member Author

aliu39 commented Jul 11, 2025

Re: cursor - change-tracking-index is still there under platform-includes/feature-flags/. This content is platform agnostic so there's only 1 default file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant