Skip to content

Add Sentry eventID to response #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Add Sentry eventID to response #1890

merged 1 commit into from
Feb 14, 2019

Conversation

Tommatheussen
Copy link
Contributor

Sets the eventId returned from captureException on ExpressJS middleware. This allows us to use the eventId to inform the user of a tracking ID they can use when in contact with Helpdesk.

Implements behaviour as shown in https://docs.sentry.io/platforms/node/express/
Likely an oversight that was missed when moving from Raven to the new clients?

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Sets the eventId returned from captureException on ExpressJS middleware. This allows us to use the eventId to inform the user of a tracking ID they can use when in contact with Helpdesk. 

Implements behaviour as shown in https://docs.sentry.io/platforms/node/express/
Likely an oversight that was missed when moving from Raven to the new clients?
@kamilogorek kamilogorek merged commit 21a449b into getsentry:master Feb 14, 2019
@kamilogorek
Copy link
Contributor

You are totally right –

var eventId = self.captureException(err, {req: req});
res.sentry = eventId;

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants