fix: null ref in view hierarchy #1919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
commented
Nov 23, 2024
| var extras = new List<string>(components.Count); | ||
| foreach (var component in components) | ||
| { | ||
| if (component?.GetType().Name is { } componentName) |
There was a problem hiding this comment.
The stack trace on #1918 led me to believe GetComponents is adding null to entries to the List it receives as argument.
|
CI is showing green here but only 5 checks show. I had to cancel CI due to #1920 |
CI will skip if the only changes are made to sentry-unity/.github/workflows/ci.yml Lines 3 to 8 in 89c7acf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1918
Skips possible
nullcomponents before trying to get their type info.Not sure how to test this because it depends on a Unity API
GetComponentsAlso: replaced the LINQ call with a foreach and allocated a new List with the known size to avoid resizes.