ref(dropdownMenu): Remove showDividers prop & modify default divider rules
#40982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
vuluongj20
commented
Nov 3, 2022
Comment on lines
121
to
125
| const showDividers = useMemo( | ||
| () => stateCollection.some(item => !!item.props.details), | ||
| [stateCollection] | ||
| ); | ||
|
|
There was a problem hiding this comment.
Logical result of the two rules mentioned above: if any item in the menu has some details text, then the entire menu should have dividers.
size-limit report 📦
|
malwilley
reviewed
Nov 3, 2022
| @@ -118,15 +118,20 @@ function DropdownMenu({ | |||
| [menuProps, hasFocus] | |||
| ); | |||
|
|
|||
| const showDividers = useMemo( | |||
There was a problem hiding this comment.
No need for a useMemo here since it returns a primitive and the operation is quick
malwilley
approved these changes
Nov 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the
showDividersprop in dropdown menus hasn't been very useful (it's only used in one component). Also, we want to enforce certain rules for when to show dividers in a menu and don't want too much deviation from those rules. I think we can remove the prop in favor of some slightly modified default rules. Those rules include:detailstext (small gray text in a second line), it should have dividers around itBefore:
After:
