dev: upgrade stripe to v5 #88755
Merged
dev: upgrade stripe to v5 #88755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88755 +/- ##
==========================================
- Coverage 87.80% 87.76% -0.05%
==========================================
Files 10292 10183 -109
Lines 583943 582366 -1577
Branches 22577 22348 -229
==========================================
- Hits 512756 511097 -1659
- Misses 70773 70889 +116
+ Partials 414 380 -34 |
vbro
approved these changes
Apr 30, 2025
|
@vbro Nothing specifically from v5, but yeah the goal would be to get us on latest. There are some cool things enabled with later versions like described here: https://docs.stripe.com/upgrades#2023-08-16 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
This PR aims to upgrade stripe to v5.5.0 from v4.2.0. No breaking changes that I could see we were affected by -- - Checked as many references to stripe.`resource`.retrieve() as I could find to see if we were calling .save() on any of them and couldn't find one - I used this regex stripe\.[a-zA-Z]+\.retrieve if anyone wants to double check - Not using orders or SKU object so unaffected by those changes [Notion](https://www.notion.so/sentry/Upgrading-Stripe-from-v3-to-latest-1c88b10e4b5d80adbf87f574c2929d27?p=1c88b10e4b5d81c2aa38d9dc0046e547&pm=s) [Migration Guide](https://github.com/stripe/stripe-python/wiki/Migration-guide-for-v5) [Changelog](https://github.com/stripe/stripe-python/releases?page=15) <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to upgrade stripe to v5.5.0 from v4.2.0.
No breaking changes that I could see we were affected by --
resource.retrieve() as I could find to see if we were calling .save() on any of them and couldn't find oneNotion
Migration Guide
Changelog
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.