Skip to content

fix(ourlogs): Avoid unnecessary wrapping #90726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2025
Merged

Conversation

colin-sentry
Copy link
Member

Basic rendered in this context can contain a nowrapped link, just use the attribute value.

@colin-sentry colin-sentry requested a review from a team as a code owner May 1, 2025 15:25
@colin-sentry colin-sentry requested review from k-fish and removed request for a team May 1, 2025 15:25
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 1, 2025
@colin-sentry colin-sentry changed the title fix(ourlogs): Avoid unnecessary wrapping, yo fix(ourlogs): Avoid unnecessary wrapping May 1, 2025
function hasNoWrapRecursive(element: HTMLElement) {
const children = element.children;
for (const child of children) {
if (getComputedStyle(child).whiteSpace === 'nowrap') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gnarly, but sure, let's try it

@colin-sentry colin-sentry merged commit 6aaa91a into master May 1, 2025
42 checks passed
@colin-sentry colin-sentry deleted the nowrap_the_wrap_wrap branch May 1, 2025 16:42
Copy link

sentry-io bot commented May 8, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TestingLibraryElementError: Unable to find an element by: [data-test-id="tree-key-project.id"] Object.?(logsTableRow.spec.tsx) View Issue

Did you find this useful? React with a 👍 or 👎

andrewshie-sentry pushed a commit that referenced this pull request May 12, 2025
Basic rendered in this context can contain a nowrapped link, just use
the attribute value.
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants