chore(fe): Convert <IntegrationCodeMappings /> to an FC
#90820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
leeandher
added a commit
that referenced
this pull request
May 5, 2025
While working on #90820 I noticed the repo list doesn't paginate. The page links were setting the query params, but the api call didn't use em.
static/app/views/settings/organizationIntegrations/integrationCodeMappings.tsx
Show resolved
Hide resolved
michellewzhang
approved these changes
May 5, 2025
leeandher
force-pushed
the
leander/convert-gh-mapping
branch
from
4a4d11a to
ef5827b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #90820 +/- ##
==========================================
- Coverage 87.80% 84.02% -3.78%
==========================================
Files 10283 10283
Lines 583590 583517 -73
Branches 22579 22577 -2
==========================================
- Hits 512407 490304 -22103
- Misses 70769 92799 +22030
Partials 414 414 |
scttcper
approved these changes
May 5, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
While working on #90820 I noticed the repo list doesn't paginate. The page links were setting the query params, but the api call didn't use em.
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
Pretty straight forward, the only two interesting changes are: - All the special casing for handling the cursor has been removed. There were workarounds to handle the cursor in state and manually update the cache, but it's much simpler to just omit the cursor when a new tab is selected. it honestly didn't even make sense because refreshing the page after clicking a new tab would yield new results when we suddenly start respecting the cursor (I also introduced this workaround 3 years ago so i dont mind dogging on it lol) - Instead of trying to update the list to include the newly created code mapping, just refetch. The list is sorted so if the codemapping started with an A, but was on page 10, the results would appear as [Aproj, Xproj, Yproj, Zproj] then refreshing would cause it to disappear. This means after manually creating a code mapping, you won't immediately see it in the list, though only if you have >100. TBH these pages should have search anyway.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty straight forward, the only two interesting changes are: