Skip to content

Conversation

@kassane
Copy link
Contributor

@kassane kassane commented Sep 3, 2023

No description provided.

@alonfaraj
Copy link
Contributor

Good idea to add every build system mentioned in llama.cpp Readme!

I'm wondering if zig worth a separate workflow or it better to integrate it with the existing build workflow.

@kassane
Copy link
Contributor Author

kassane commented Sep 4, 2023

Good idea to add every build system mentioned in llama.cpp Readme!

The readme has a brief introduction on how to use zig build.

I'm wondering if zig worth a separate workflow or it better to integrate it with the existing build workflow.

I chose to separate the CI/CD from the zig, in case the @ggerganov author wants to discontinue it for any reason. And it would also be easier to detect the problem individually.

@ggerganov
Copy link
Member

We can update to latest master and merge this if it is still of interest

Signed-off-by: Matheus Catarino França <[email protected]>
@kassane
Copy link
Contributor Author

kassane commented Oct 8, 2023

We can update to latest master and merge this if it is still of interest

Done! (rebased)

@ggerganov ggerganov merged commit eee42c6 into ggml-org:master Oct 8, 2023
@kassane kassane deleted the zig-fix branch October 8, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants