Simplify the SIMD code #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
force-pushed
the
simd
branch
3 times, most recently
from
9e726a3 to
bad040f
Compare
rock3125
pushed a commit
to rock3125/whisper.cpp
that referenced
this pull request
Feb 21, 2023
* ggml : simplify the SIMD code * ggml : generic reduce for all register sizes + comments
anandijain
pushed a commit
to anandijain/whisper.cpp
that referenced
this pull request
Apr 28, 2023
* ggml : simplify the SIMD code * ggml : generic reduce for all register sizes + comments
jacobwu-b
pushed a commit
to jacobwu-b/Transcriptify-by-whisper.cpp
that referenced
this pull request
Oct 24, 2023
* ggml : simplify the SIMD code * ggml : generic reduce for all register sizes + comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to simplify and unify the SIMD implementation for various architectures.
The idea is similar to #95 (comment)
We define a common subset of C macros which map to specific intrinsics based on the current architecture:
We then implement the SIMD functions using only these macros.
Refactored functions:
Supported and tested architectures:
Still not sure if this would be easier to maintain, but I will give it a try