Skip to content

Main #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 53 commits into from
Closed

Main #1855

Changes from 1 commit
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
f600e92
Omit GitLab client secret
hickford Feb 23, 2024
5d98ece
build(deps): bump DavidAnson/markdownlint-cli2-action
dependabot[bot] Sep 11, 2024
bc4dfa9
docs: update required dotnet-sdk version in install.md
xtqqczze Sep 30, 2024
b164e4a
docs: update required dotnet-sdk version in install.md (#1713)
Oct 1, 2024
32d205b
settings: add allow unsafe remotes option
mjcheetham Oct 7, 2024
2fbe3d6
bitbucket: support GCM_ALLOW_UNSAFE_REMOTES option
mjcheetham Oct 7, 2024
6b87cc7
github: support GCM_ALLOW_UNSAFE_REMOTES option
mjcheetham Oct 7, 2024
f2652f3
gitlab: support GCM_ALLOW_UNSAFE_REMOTES option
mjcheetham Oct 7, 2024
7a613f3
azrepos: support GCM_ALLOW_UNSAFE_REMOTES option
mjcheetham Oct 7, 2024
fc067e8
generic: support GCM_ALLOW_UNSAFE_REMOTES option
mjcheetham Oct 7, 2024
004b19e
docs: update Secret Service links
dscho Oct 7, 2024
2d10c92
docs: update Secret Service links (#1722)
Oct 7, 2024
7b60eee
Add control over use of unsafe remotes (#1721)
Oct 7, 2024
1c80d4b
Omit GitLab client secret (#1538)
Oct 7, 2024
180a9e4
build(deps): bump lycheeverse/lychee-action from 1.9.3 to 2.0.0
dependabot[bot] Oct 8, 2024
c853292
build(deps): bump lycheeverse/lychee-action from 1.9.3 to 2.0.0 (#1725)
Oct 9, 2024
535ed76
build(deps): bump lycheeverse/lychee-action from 2.0.0 to 2.0.2
dependabot[bot] Oct 14, 2024
a96afbb
credstore: add no-op credential storage option
mjcheetham Oct 15, 2024
969e452
Add no-op credential storage option (#1740)
Oct 15, 2024
178a7d0
ci: move to "more official" tgagor/centos
dscho Oct 21, 2024
2bc4b4a
ci: move to "more official" tgagor/centos (#1746)
dscho Oct 21, 2024
2dece79
install-from-source: avoid using `which` before it is installed
dscho Oct 21, 2024
89adece
install-from-source(mariner): awk is required to make dotnet-install.…
dscho Oct 21, 2024
7b721ea
install-from-source(mariner): ensure that CA certificates are installed
dscho Oct 21, 2024
41a26cf
ci: also verify that installation works on Mariner and Arch Linux
dscho Oct 21, 2024
6c916a3
ci: add Mariner and Arch Linux (#1747)
Oct 22, 2024
fc8622c
build(deps): bump lycheeverse/lychee-action from 2.0.0 to 2.0.2 (#1738)
Oct 22, 2024
ae009e1
build(deps): bump DavidAnson/markdownlint-cli2-action from 16.0.0 to …
mjcheetham Oct 22, 2024
4431516
build(deps): bump azure/trusted-signing-action from 0.4.0 to 0.5.0
dependabot[bot] Oct 23, 2024
ca7a0d6
build(deps): bump actions/setup-dotnet from 4.0.1 to 4.1.0
dependabot[bot] Oct 24, 2024
557937a
fix wrong bash if-else syntax
JaoSchmidt Oct 28, 2024
674aa73
build(deps): bump actions/setup-dotnet from 4.0.1 to 4.1.0 (#1751)
mjcheetham Oct 29, 2024
aff97de
build(deps): bump azure/trusted-signing-action from 0.4.0 to 0.5.0 (#…
mjcheetham Oct 29, 2024
749e287
fix wrong bash if-else syntax (#1752)
mjcheetham Oct 29, 2024
61e4fa4
streams: only consider LF and CRLF as newlines
mjcheetham Oct 29, 2024
99e2f7f
release.yml: use gatewatcher mac app certificate
mjcheetham Oct 30, 2024
786ab03
VERSION: bump to 2.6.1
mjcheetham Oct 30, 2024
628acd0
add support for Linux arm64 and Linux arm
theofficialgman Jun 5, 2024
31ce754
add support for Linux arm64 and Linux arm (#1633)
Nov 6, 2024
5cd01b6
don't require runtime to be set to install from source
theofficialgman Nov 6, 2024
17250be
don't require runtime to be set to install from source (#1757)
Nov 6, 2024
47b731e
build(deps): bump lycheeverse/lychee-action from 2.0.2 to 2.1.0
dependabot[bot] Nov 7, 2024
b378f2a
build(deps): bump DavidAnson/markdownlint-cli2-action
dependabot[bot] Nov 15, 2024
4e26608
build(deps): bump lycheeverse/lychee-action from 2.0.2 to 2.1.0 (#1760)
mjcheetham Dec 9, 2024
2e505a6
build(deps): bump DavidAnson/markdownlint-cli2-action from 17.0.0 to …
mjcheetham Dec 9, 2024
235d636
build(deps): bump actions/setup-dotnet from 4.1.0 to 4.2.0
dependabot[bot] Dec 27, 2024
21fda9f
build(deps): bump actions/setup-dotnet from 4.1.0 to 4.2.0 (#1799)
mjcheetham Jan 3, 2025
4c32c09
Merge branch 'newline-fix' into HEAD
vdye Jan 14, 2025
5f6d32a
macospreferences: add class to read macOS app preferences
mjcheetham Jan 24, 2025
b05317f
macossettings: implement default settings for macOS
mjcheetham Jan 24, 2025
b62021f
Add support for macOS enterprise deployable default settings (#1811)
mjcheetham Jan 28, 2025
7b3546b
Enhance VSCode configuration with new launch and task options for .NE…
pjn94 Mar 14, 2025
f4072e8
Update Dependabot configuration for devcontainers and add code citati…
pjn94 Mar 14, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
install-from-source: avoid using which before it is installed
The `which` executable must often be installed because it is missing
from many a Docker image. Therefore, it won't _really_ work if one
checks `which which` to figure out whether `which` is installed.

Let's avoid this by using `type`, which is a shell builtin for most
shells.

The `type` utility is specified in the POSIX standard, as per
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/type.html,
yet neither command-line options nor output is standardized. The only
thing we _can_ rely on is the exit status.

Note: _Technically_, this poses a change of behavior, as `which`
resolves only to executables that are on the `PATH` while `type` will
also happily report shell builtins. However, this is a net improvement:
If running the script in, say, BusyBox, where many of the common
utilities (including `which`!) are shell builtins, we would like to
avoid forcefully installing the packages without need.

Signed-off-by: Johannes Schindelin <[email protected]>
  • Loading branch information
dscho committed Oct 21, 2024
commit 2dece79f0bf3c4d16da7b30833bd21fd271bee03
2 changes: 1 addition & 1 deletion src/linux/Packaging.Linux/install-from-source.sh
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ install_packages() {

for package in $packages; do
# Ensure we don't stomp on existing installations.
if [ ! -z $(which $package) ]; then
if type $package >/dev/null 2>&1; then
continue
fi

Expand Down