git-artifacts: suggest to validate installer in a PR comment #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
force-pushed
the
suggest-to-validate-installer
branch
from
087abbb to
ef64511
Compare
|
Here is the PR comment that was added in this |
.github/workflows/git-artifacts.yml
Outdated
| owner: process.env.OWNER, | ||
| repo: process.env.REPO, | ||
| issue_number: data.items[0].number, | ||
| body: `@${data.items[0].user.login}, ${body}`, |
There was a problem hiding this comment.
Looking at the example comment here, you may want to add a \n line break after @${data.items[0].user.login}, so that the ## header gets rendered correctly. WDYT?
There was a problem hiding this comment.
Excellent point! I changed it so that @dscho ☝️ will be appended instead.
It is currently a bit cumbersome to find the download link to the installer artifact, and I even missed that it was available for testing already while the `aarch64` stuff was still being built. Let's imitate c99c7f2 (release-git(announcement): add a helpful comment, 2025-03-11) and add a helpful PR comment not only when the release finished, but also when the x86_64 installer was successfully uploaded and is ready for manual testing. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
suggest-to-validate-installer
branch
from
ef64511 to
740a856
Compare
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently a bit cumbersome to find the download link to the installer artifact, and I even missed that it was available for testing already while the
aarch64stuff was still being built.Let's imitate c99c7f2 (release-git(announcement): add a helpful comment, 2025-03-11) and add a helpful PR comment not only when the release finished, but also when the x86_64 installer was successfully uploaded and is ready for manual testing.