vendor: don't remove necessary dependencies #3356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since before the Makefile was introduced, we have removed the go-spew and go-difflib dependencies, since they are not necessary in order to build or develop Git LFS. Homebrew running Go 1.11.1 during build, however, requires them. In the interim before this commit is released, we run `make vendor RM=true` to refresh the vendor tree without removing these dependencies. In the future, we'll be able to remove this changed introduced into Homebrew by not removing the dependencies in the first place. Since this commit removes the only usage of $(RM), we remove its definition, too.
4 tasks
bk2204
approved these changes
Nov 2, 2018
This was referenced Nov 2, 2018
bk2204
added a commit
that referenced
this pull request
Nov 28, 2018
vendor: don't remove necessary dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since before the Makefile was introduced, we have removed the go-spew
and go-difflib dependencies, since they are not necessary in order to
build or develop Git LFS.
Homebrew running Go 1.11.1 during build, however, requires them. In the
interim before this commit is released, we run
make vendor RM=truetorefresh the vendor tree without removing these dependencies. In the
future, we'll be able to remove this changed introduced into Homebrew by
not removing the dependencies in the first place.
Since this commit removes the only usage of $(RM), we remove its
definition, too.
/cc @git-lfs/core