Skip to content

.github/workflows: temporarily fix path on Windows #3990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

bk2204
Copy link
Member

@bk2204 bk2204 commented Jan 17, 2020

There's a bug with Actions right now that causes the path to be set incorrectly, and as a result, this causes Windows binaries to be executed in some cases instead of the binaries that come with Git Bash. This shows up in our test suite as a hang during the execution of t-credentials.sh.

Since we can't build or release software while the Actions workflows aren't working, let's adjust the path temporarily so that things work as expected.

There's a bug with Actions right now that causes the path to be set
incorrectly, and as a result, this causes Windows binaries to be
executed in some cases instead of the binaries that come with Git Bash.
This shows up in our test suite as a hang during the execution of
t-credentials.sh.

Since we can't build or release software while the Actions workflows
aren't working, let's adjust the path temporarily so that things work as
expected.
@bk2204 bk2204 requested a review from a team January 17, 2020 22:18
@bk2204 bk2204 marked this pull request as ready for review January 17, 2020 22:18
Copy link
Member

@chrisd8088 chrisd8088 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply 🔧 as needed!

@bk2204 bk2204 merged commit b9d8d44 into git-lfs:master Jan 21, 2020
@bk2204 bk2204 deleted the windows-ci branch January 21, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants