Use separate buffers for stdout and stderr on executing git-lfs-authenticate #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nticate It's fix authentication issue on ssh error messages like: ``` X11 forwarding request failed ```
|
This looks reasonable to me 👍 |
| // Save stdout and stderr in separate buffers | ||
| var outbuf, errbuf bytes.Buffer | ||
| cmd.Stdout = &outbuf | ||
| cmd.Stderr = &errbuf |
There was a problem hiding this comment.
Is that strictly allowed? I thought the only supported way was to read from cmd.StdErrPipe() and cmd.StdOutPipe()
There was a problem hiding this comment.
I dont know. This fragment was found on StackOverflow: http://stackoverflow.com/questions/31095699/return-cmd-stdout-and-stderr-as-string-instead-of-printing-to-console-in-golang/31095907
I have no golang experience.
There was a problem hiding this comment.
Never mind, I see it's OK before Start(). I've just never seen that approach before, useful :) [Edit]Got that from reading the golang code, it's a totally valid approach, if not one that's really shown in golang docs/examples.
|
👍 |
technoweenie
added a commit
that referenced
this pull request
Oct 19, 2015
Use separate buffers for stdout and stderr on executing git-lfs-authenticate
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's fix authentication issue on ssh error messages like: