Skip to content

Partially committed new files don't leave uncommitted changes #8213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Byron opened this issue Apr 18, 2025 · 0 comments · Fixed by #8291
Closed

Partially committed new files don't leave uncommitted changes #8213

Byron opened this issue Apr 18, 2025 · 0 comments · Fixed by #8291
Assignees
@Byron
Labels
bug Something isn't working V3 The ominous upcoming major release should address this issue, eventually

Comments

@Byron
Copy link
Collaborator

Byron commented Apr 18, 2025

I would also expect the unselected lines to show up as uncommitted changes, but that didn't seem to be the case judging from the screenshots. If that's the case, it would be a grave bug.

@Byron The unselected lines simply disappeared, this screenshot was taken immediately after the selected lines were committed.

Originally posted by @JoyHak in #8153

Reproduction

seq 4 >untrackedfile

In GitButler (v3) select the first and last line (even though the actual lines don't matter as long as it's not the whole hunk), then commit.

There are no uncommitted changes left, even though that's the expectation.

The Issue

The index is updated with the partially committed file, but it's also set to be up-to-date even though it's not.
@Byron Byron added bug Something isn't working V3 The ominous upcoming major release should address this issue, eventually labels Apr 18, 2025
@Byron Byron self-assigned this Apr 18, 2025
@Byron Byron mentioned this issue Apr 18, 2025
Closed
Byron added a commit to Byron/gitbutler that referenced this issue Apr 28, 2025
@Byron
Reproduce and fix gitbutlerapp#8213
965b614
@Byron Byron mentioned this issue Apr 28, 2025
Merged
3 tasks
Byron added a commit to Byron/gitbutler that referenced this issue Apr 28, 2025
@Byron
Reproduce and fix gitbutlerapp#8213
18bb9a3
Byron added a commit to Byron/gitbutler that referenced this issue Apr 28, 2025
@Byron
Reproduce and fix gitbutlerapp#8213
137a527
Byron added a commit to Byron/gitbutler that referenced this issue Apr 28, 2025
@Byron
Reproduce and fix gitbutlerapp#8213
d2d90e7
Byron added a commit to Byron/gitbutler that referenced this issue Apr 28, 2025
@Byron
Reproduce and fix gitbutlerapp#8213
d96b3be 
The issue in testing was that racy-git is causing `gix status` to come up with changes that in practice
wouldn't show as the index is marked as up-to-date.
Byron added a commit to Byron/gitbutler that referenced this issue Apr 28, 2025
@Byron
Reproduce and fix gitbutlerapp#8213
e5f271a 
The issue in testing was that racy-git is causing `gix status` to come up with changes that in practice
wouldn't show as the index is marked as up-to-date.
Byron added a commit to Byron/gitbutler that referenced this issue Apr 28, 2025
@Byron
Reproduce and fix gitbutlerapp#8213
4a3ffee 
The issue in testing was that racy-git is causing `gix status` to come up with changes that in practice
wouldn't show as the index is marked as up-to-date.
@Byron Byron closed this as completed in 36ca9d2 Apr 28, 2025
Byron added a commit that referenced this issue Apr 28, 2025
@Byron
Merge pull request #8291 from Byron/fix-8213
40e5508 
Reproduce and fix #8213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Byron Byron

Labels
bug Something isn't working V3 The ominous upcoming major release should address this issue, eventually
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reproduce and fix #8213 Byron/gitbutler
1 participant
@Byron