Bitbucket PR Url is incorrect when there is a semver in the branch

[thattomperson]

Version

0.14.18

Operating System

macOS

Distribution Method

dmg (Mac OS - Apple Silicon)

Describe the issue

I currently have my target set to a branch called preview/v1.1.0
When clicking on the Open In Browser button on a lane, it takes me to a page like
https://bitbucket.org/org/repo/branch/branch-1?dest=v1.1.0

the ?dest is missing the preview/ prefix

How to reproduce (Optional)

No response

Expected behavior (Optional)

No response

Relevant log output (Optional)

[Byron]

Thanks a lot for reporting!

The application seems to build the URL here:

gitbutler/apps/desktop/src/lib/forge/bitbucket/bitbucketBranch.ts

Line 9 in 134d6a9

this.url = `${baseUrl}/branch/${name}?dest=${baseBranch}`;

But it wasn't immediately clear how baseBranch is turned into something partial. Maybe this also needs URL-encoding so the /-character doesn't trip anything up.
In any case, I think @estib-vega will know what to do here.

[mrsimb]

It does encode the parameter
https://bitbucket.org/mrsimb/test/branches/compare/preview%2Fv1.0.0%0Dmain

@Byron Would you mind if i take this issue?

[Byron]

I think both @estib-vega and me will be looking forward to your PR :)!

[mrsimb]

Nice!