mutations are typed correctly #8122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
The types for the mutation hooks where defined loosely and outside their value declarations. This lead to the hooks being mistyped by mistake. - Move the hooks types to where the hook functions are. - Strengthen the types so that we don't mistype by accident.
estib-vega
commented
Apr 11, 2025
Comment on lines
-232
to
-235
| promise = dispatchResult; | ||
| const result = await promise.unwrap().catch((error) => { | ||
| onError?.(error, queryArg); | ||
| }); |
There was a problem hiding this comment.
don't swallow the error
Comment on lines
+286
to
+290
| } catch (error: unknown) { | ||
| if (onError && isTauriCommandError(error)) { | ||
| onError(error, queryArg); | ||
| } | ||
| throw error; |
There was a problem hiding this comment.
On error is called, but the error is thrown still
| } | ||
|
|
||
| return result; |
There was a problem hiding this comment.
don't return the dispatch result
Comment on lines
+253
to
+260
| const result = await dispatchResult.unwrap(); | ||
| sideEffect?.(result, queryArg); | ||
| return result; | ||
| } catch (error: unknown) { | ||
| if (onError && isTauriCommandError(error)) { | ||
| onError(error, queryArg); | ||
| } | ||
| throw error; |
There was a problem hiding this comment.
return the mutation result or throw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types for the mutation hooks where defined loosely and outside their value declarations. This lead to the hooks being mistyped by mistake.