Skip to content

fix(editor): simplify upload confirmation modal behavior #8204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025
Merged

fix(editor): simplify upload confirmation modal behavior #8204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(editor): simplify upload confirmation modal behavior 
Remove the 'needs-re-drop' argument from uploadConfirmationModal.show()
to streamline the upload confirmation flow. Also, eliminate the conditional
message prompting users to re-drop files, reducing redundancy and
improving user experience during file attachment in MessageEditor.
  • Loading branch information
@estib-vega
estib-vega committed Apr 17, 2025
commit 13f813a3de8c9b15886bfef96ec8dc16c3b2a40f
10 changes: 2 additions & 8 deletions apps/desktop/src/components/v3/editor/MessageEditor.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@
return onDropFiles(files);
}

uploadConfirmationModal?.show('needs-re-drop');
uploadConfirmationModal?.show();
return undefined;
}

Expand Down Expand Up @@ -179,7 +179,7 @@
close();
}}
>
{#snippet children(maybeCode)}
{#snippet children()}
<p>
Thanks for your interest on attaching a file to this message.
<br />
Expand All @@ -200,12 +200,6 @@
<em>{'Your GitButler team <3'}</em>
</p>
<br />
{#if maybeCode === 'needs-re-drop'}
<p>
<b>PS: Please re-drop the file to upload it.</b>
</p>
<br />
{/if}
<div style="display: flex; align-items: center; gap: 4px">
<Checkbox small bind:checked={$doNotShowUploadWarning} />
<span> Do not bring this up again </span>
Expand Down
Loading