Fix a couple of UI bugs #8257
Merged
Fix a couple of UI bugs #8257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
mtsgrd
commented
Apr 24, 2025
| {@const selected = selection?.current?.branchName === branchName} | ||
| {@const selected = | ||
| selection?.current?.branchName === branchName && | ||
| selection?.current.commitId === undefined} |
There was a problem hiding this comment.
@PavelLaptev just want to double check in case I made an incorrect change here. When a commit is selected, should the "branch" be selected or unselected?
There was a problem hiding this comment.
Thanks, @mtsgrd!
A branch shouldn't be in the "selected" state if a commit is selected.
Only one thing should be selected within a branch card at a time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⧓ Review in Butler Review
#0jjNM6pEAFix a couple of UI bugs
3 commit series (version 1)
Please leave review feedback in the Butler Review