fix(github): Include owner in head parameter for PRs from forks #8313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@matthewevans is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
matthewevans
force-pushed
the
fix/create-pr-from-fork
branch
from
d158433 to
f00abb9
Compare
matthewevans
force-pushed
the
fix/create-pr-from-fork
branch
from
f00abb9 to
364af71
Compare
|
Thanks for tackling this - it's interesting that this issue didn't show up before. The implementation looks good to me, but I didn't run it and @estib-vega would definitely know more. |
matthewevans
force-pushed
the
fix/create-pr-from-fork
branch
from
3099e75 to
c3a3a6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating Pull Requests from a fork to an upstream repository failed with a GitHub API error:
{"resource":"PullRequest","field":"head","code":"invalid"}.🧢 Changes
GitHubPrService.createPrto accept the fork owner (headOwner) and format theheadparameter asowner:branch.ReviewCreation.svelteto use the existingparseRemoteUrlutility to extract the owner from the project's Git URL and pass it tocreatePr.☕️ Reasoning
The API call was missing the required
owner:prefix in theheadparameter when the source branch exists on a fork.