Fix persisteds having isolated reactivity #9305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Caleb-T-Owens
force-pushed
the
fix-persisteds-having-isolated-reactivity
branch
from
6f6e5b3 to
938aead
Compare
This change makes persisteds behave like a singleton instance based on the key passed in. This makes use of the JS `WeakMap` to make sure that they can still be GCed correctly
Caleb-T-Owens
force-pushed
the
fix-persisteds-having-isolated-reactivity
branch
from
938aead to
1f40918
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes persisteds behave like a singleton instance based on the key passed in.
This makes use of the JS
WeakMapto make sure that they can still be GCed correctly