Refactor command name handling for back end queries #9314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
mtsgrd
commented
Jul 8, 2025
Comment on lines
+56
to
58
| query: ({ projectId, changes }) => ({ | ||
| params: { projectId, changes } | ||
| }), |
There was a problem hiding this comment.
All these kinds of arguments can be reduced to (x)=>x once all the build.query() endpoints have been updated to use extraOptions.
krlvi
reviewed
Jul 8, 2025
README.md
Outdated
| @@ -1,3 +1,5 @@ | |||
| Hello | |||
In order to better capture metrics we need the backend command name to be defined on the rtkq queries directly, rather than as part of the arguments to the base query. What would be ideal is if we could modify the `MutationDefintion` to have the extra properties directly, rather than constantly nesting them inside `extraOptions`. For now I am leaving `build.query()` definitions alone, and reliant on passing `command` through the query args. Before we migrate them over we need to implement the posthog stuff on the query hooks (the ones touched here are all mutations).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to better capture metrics we need the backend command name to
be defined on the rtkq queries directly, rather than as part of the
arguments to the base query.
What would be ideal is if we could modify the
MutationDefintiontohave the extra properties directly, rather than constantly nesting them
inside
extraOptions.For now I am leaving
build.query()definitions alone, and reliant onpassing
commandthrough the query args. Before we migrate them over weneed to implement the posthog stuff on the query hooks (the ones touched
here are all mutations).