Skip to content

feat: add metrics instrumentation to internal MCP server #9334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

estib-vega
Copy link
Contributor

  • Instrument the internal MCP server with metrics:
    • Capture duration, endpoint name, and client details (name and version) for important endpoints: project_status, commit, amend, branch_details, create_branch.
    • Integrate the Metrics handling struct and event capturing in MCP server logic.
    • Pass AppSettings and client_info as needed through server instantiation.
  • Add a new McpInternal variant to EventKind for more granular event typing.
  • Update relevant method signatures and invocations.

This change provides foundational metrics collection suitable for internal observability purposes in the MCP server.

- Instrument the internal MCP server with metrics:
  - Capture duration, endpoint name, and client details (name and version) for important endpoints: project_status, commit, amend, branch_details, create_branch.
  - Integrate the Metrics handling struct and event capturing in MCP server logic.
  - Pass AppSettings and client_info as needed through server instantiation.
- Add a new `McpInternal` variant to EventKind for more granular event typing.
- Update relevant method signatures and invocations.

This change provides foundational metrics collection suitable for internal observability purposes in the MCP server.
Copy link

vercel bot commented Jul 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2025 11:14am
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2025 11:14am

@github-actions github-actions bot added the rust Pull requests that update Rust code label Jul 10, 2025
@estib-vega estib-vega enabled auto-merge July 10, 2025 11:21
@estib-vega estib-vega merged commit 582fd09 into master Jul 10, 2025
20 checks passed
@estib-vega estib-vega deleted the mcp-metrics-instrumentation branch July 10, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant