toggle user sybils: add comparisons to thresholds #10676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlessa
requested review from
thelostone-mc,
gdixon,
chibie,
nutrina and
tim-schultz
as code owners
thelostone-mc
approved these changes
Jun 14, 2022
nutrina
added a commit
that referenced
this pull request
Jun 15, 2022
* Adjusting log messages + linter fixes (#10667) Co-authored-by: Gerald Iakobinyi-Pich <[email protected]> * Fixes for bounties: (#10671) - layout for contact details (avoid overlapping, wrap the line with contact details) - editing bounty that was not reserved was not working Co-authored-by: Gerald Iakobinyi-Pich <[email protected]> * toggle user sybils: add comparisons to thresholds (#10676) * Adding try + catch + error message when scoring passport. Co-authored-by: Gerald Iakobinyi-Pich <[email protected]> Co-authored-by: Danilo Lessa Bernardineli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
bsci_scriptmethod was missing the comparison between the dataset elements and the relevant thresholds, therefore making the sybil flags more conservative than it should (only values = 0 or 1 were taken into consideration). This PR fixes that by introducing the comparison operator, which makes the script behave as expected.Testing
Logical tests were done locally on Jupyter Notebooks to ensure that the sybil flags were equal to what was expected by using the
aggregate_scorecolumn