Skip to content

feat: purge std bounty creation + use web3 modal for payout #6940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jun 30, 2020

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jun 22, 2020

Description

  • Bounty Creation

    • update token.js to cater for new ETH flow with the right web3_type
    • allow rinkeby -> (how do we control this)
    • retire ETH.js
    • Do we collect funder address
    • feature bounty + fee
  • Start Work Flow

  • Approve / Reject Flow

  • Submit Work Flow

    • Ability to detect fulfiller address (Do we want this)
  • Payout

    • ability to auto detect address
    • async payout
    • new payout flow
    • add checks to ensure wallet is unlocked
    • ensure if bounty is mainnet -> allow payout in mainnet only
  • Close Bounty

  • Cancel Bounty

  • Increase Bounty

  • Update Bounty Details

  • Model Changes

@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #6940 into master will decrease coverage by 0.04%.
The diff coverage is 21.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6940      +/-   ##
==========================================
- Coverage   26.47%   26.42%   -0.05%     
==========================================
  Files         299      300       +1     
  Lines       28843    29048     +205     
  Branches     4227     4318      +91     
==========================================
+ Hits         7635     7675      +40     
- Misses      20937    21087     +150     
- Partials      271      286      +15     
Impacted Files Coverage Δ
app/app/urls.py 86.20% <ø> (ø)
app/dashboard/admin.py 64.73% <ø> (ø)
...d/management/commands/sync_pending_fulfillments.py 0.00% <0.00%> (ø)
app/dashboard/sync/helpers.py 27.27% <0.00%> (ø)
app/marketing/mails.py 10.94% <ø> (ø)
app/dashboard/helpers.py 13.94% <10.00%> (-0.25%) ⬇️
app/dashboard/utils.py 40.47% <10.00%> (-0.12%) ⬇️
app/dashboard/views.py 10.60% <11.11%> (+0.04%) ⬆️
app/retail/views.py 21.14% <20.00%> (-0.03%) ⬇️
app/dashboard/sync/eth.py 23.07% <23.07%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24f50e2...46b33b2. Read the comment docs.

@octavioamu octavioamu marked this pull request as ready for review June 27, 2020 06:01
@octavioamu
Copy link
Contributor

hackathon form ready we can continue the normal form in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants