Skip to content

Let users ingest missing contributions #8274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Jan 20, 2021

Closes #8250

  • The new page is located at /grants/add-missing-contributions
  • The logic used in ingest_grant_txns.py was copied in the new endpoint that lives in the ingest_contributions method of views.py
  • Video shown below
69cc0e86bc30477d9eaf74b8f29653c1.mp4

@mds1 mds1 changed the base branch from master to stable January 20, 2021 20:28
@mds1 mds1 force-pushed the let-users-ingest-missing-contributions branch from 20ae4ac to 9dac950 Compare January 20, 2021 20:28
Copy link
Contributor

@PixelantDesign PixelantDesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. How do users get here?

@mds1
Copy link
Contributor Author

mds1 commented Jan 20, 2021

@PixelantDesign For now we will just send the link to users when they report missing contributions

@thelostone-mc thelostone-mc merged commit 891b0f8 into gitcoinco:stable Jan 26, 2021
print("Saved!\n")

except Exception as e:
print(e)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u probably want to logger.exception this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this was merged, I created a new PR with this change here: #8320

cc @thelostone-mc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a way for users to ingest Tx that were missed by our system:
4 participants