bug: ignore grant removed from round in clr calculation #9876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdixon
reviewed
Dec 13, 2021
gdixon
reviewed
Dec 13, 2021
| @@ -485,7 +486,11 @@ def predict_clr(save_to_db=False, from_date=None, clr_round=None, network='mainn | |||
| print(f"- starting grants iter at {round(time.time(),1)}") | |||
| # for full calc - calculate the clr for each grant given additional potential_donations | |||
| total_count = grants.count() | |||
|
|
|||
| invalid_clr_calculations = GrantCLRCalculation.objects.filter(latest=True, grantclr=clr_round.pk) | |||
There was a problem hiding this comment.
Really nice approach here!! 🚀
Co-authored-by: Graham Dixon <[email protected]>
thelostone-mc
requested review from
chibie,
frankchen07,
nutrina and
PixelantDesign
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently if during a round if a grant is removed from a CLR round, the CLRCalculation is still taked into account as the latest field is marked True and hasn't been toggled back.
This PR ensures that when the clr cals are run the next time -> it toggle the
latestflag to False for all grant's clr cals which are no longer part of the round.Refers/Fixes
https://discord.com/channels/562828676480237578/907740735602851840/919793535702691890