Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Unicode error can occur when viewing diff for PR files #1908

Closed
StanleyGoldman opened this issue Sep 11, 2018 · 0 comments
Closed

Unicode error can occur when viewing diff for PR files #1908

StanleyGoldman opened this issue Sep 11, 2018 · 0 comments
Labels
bug
Milestone
2.5.9

Comments

@StanleyGoldman
Copy link
Contributor

  1. Checkout a different branch than PR I18n pull request restore with CrowdIn support #1888 as an example
  2. Right click and "View Changes" of any zh-CN.resx file.
  3. Observe error

Note: If you are actually on the branch this error does not occur.

Images

image

image
grokys added a commit that referenced this issue Oct 23, 2018
@grokys
Don't change file encoding unnecessarily.
84c37c9 
When a file doesn't exist locally, don't change it's encoding to `Encoding.Default`, just leave it be. Fixes #1908.
@grokys grokys mentioned this issue Oct 23, 2018
Merged
@meaghanlewis meaghanlewis added this to the 2.5.9 milestone Oct 29, 2018
@drguthals drguthals mentioned this issue Nov 1, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.5.9
Development

No branches or pull requests
2 participants
@StanleyGoldman @meaghanlewis