This repository was archived by the owner on Jun 21, 2023. It is now read-only.

No error shown when creating a PR fails #2172

Closed

grokys opened this issue Jan 10, 2019 · 0 comments · Fixed by #2173

Labels

bug

Milestone

Contributor

grokys commented Jan 10, 2019 •

edited by jcansdale

Loading

Versions

GitHub Extension for Visual Studio version: >=2.6.1
Visual Studio version: All

What happened

When creating a PR fails, no error message is shown.

Steps to Reproduce

Steps to reproduce the behavior:

Create a branch with no commits
Click "Create New" on the PR list
Enter a title/description and click "Create pull request"
PR creation fails but no error is shown.

Expected behavior

An error should be shown in the GitHub pane.

Related

Nothing happens when I click Create pull request on public repository #2058: Nothing happens when I click Create pull request on public repository

The text was updated successfully, but these errors were encountered:

grokys added the bug label

grokys added a commit that referenced this issue


          Fix displaying errors in GitHub pane.

c53fa14

#1787 refactored `InfoPanel` but didn't update `GitHubPaneView` with its new behavior. So:

- Don't initialy set `infoPanel.Visibility` to `Collapsed`: `InfoPanel` will handle this itself
- Set `ShowCloseButton` to show the `x` button to close the error

Fixes #2172
Fixes #2058

grokys mentioned this issue

Fix displaying errors in GitHub pane. #2173

Merged

jcansdale mentioned this issue

Nothing happens when I click Create pull request on public repository #2058

Closed

jcansdale closed this as completed in #2173

meaghanlewis added this to the 2.6.3 milestone

jcansdale changed the title ~~No error shown when creating PR fails~~ No error shown when creating a PR fails

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.